Fix panic in validate webhook for creating spidermultusconfig #4099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyclinder
requested review from
weizhoublue,
ty-dc and
bzsuni
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-v0.8 #4099 +/- ##
================================================
+ Coverage 81.54% 82.02% +0.48%
================================================
Files 49 49
Lines 4340 4340
================================================
+ Hits 3539 3560 +21
+ Misses 640 614 -26
- Partials 161 166 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
cyclinder
force-pushed
the
cp_spidermultusconfig_0.8
branch
3 times, most recently
from
c8b91ae to
a5eeb1d
Compare
weizhoublue
changed the title
weizhoublue
changed the title
weizhoublue
approved these changes
Sep 26, 2024
ty-dc
approved these changes
Sep 26, 2024
Signed-off-by: cyclinder <[email protected]>
cyclinder
force-pushed
the
cp_spidermultusconfig_0.8
branch
from
a5eeb1d to
99ee38d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4077
Special notes for your reviewer: