-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: the pod fails to run because the certificate of the pod webhook is not up to data after helm upgrading #4420
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4420 +/- ##
==========================================
- Coverage 79.43% 79.21% -0.22%
==========================================
Files 54 54
Lines 6388 6283 -105
==========================================
- Hits 5074 4977 -97
+ Misses 1117 1110 -7
+ Partials 197 196 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dd121ad
to
d5a696e
Compare
|
I notice you add the label for cherry picking to v0.8 ? |
Yes, you are right. |
fc48d82
to
2aa8529
Compare
Using helm templates to rendering podwebhook config rather than controller genarated, which can advoid the webhook cert would be revert when helm upgrade, it can leads to pod fail to start. Signed-off-by: Cyclinder Kuo <[email protected]>
2aa8529
to
c9075f4
Compare
Using helm templates to rendering podwebhook config rather than controller genarated, which can advoid the webhook cert would be revert when helm upgrade, it can leads to pod fail to start.
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #4357
Special notes for your reviewer:
之前 podwebhookconfig 通过 controller 动态生成, 但 helm upgrade 导致 podwebhookconfig 被还原为默认的 value,这会导致 podwebhook 的证书无效,从而导致 pod 无法被创建。此 PR 将 podwebhookconfig 通过 helm templates 统一声明,通过 values 开关控制,避免更新时被还原。