Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove need for generic_const_exprs #127

Closed
aeryz opened this issue Jun 5, 2023 · 0 comments · Fixed by #128
Closed

Remove need for generic_const_exprs #127

aeryz opened this issue Jun 5, 2023 · 0 comments · Fixed by #128
Assignees
@aeryz
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.

Comments

@aeryz
Copy link
Contributor

aeryz commented Jun 5, 2023

Current implementation of ethereum-verifier makes use of the unstable feature generic_const_exprs which might be dangerous. For now, we can just pub use the constants that we need with feature gating. There will be config-minimal feature in ethereum-verifier and the library will re-export capella::minimal::* or capella::mainnet::* based on whether the feature is active or not.
@aeryz aeryz added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jun 5, 2023
@aeryz aeryz self-assigned this Jun 5, 2023
@aeryz aeryz mentioned this issue Jun 5, 2023
Merged
aeryz added a commit that referenced this issue Jun 12, 2023
@aeryz
feat(ethereum-verifier): introduce account state verification (closes #…
2e363ab 
…99, #127) (#128)

- Implements #99.
- Fixes #127. (This is also added here because it is very small.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeryz aeryz

Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ethereum-verifier): introduce account state verification (closes #99, #127) unionlabs/union
1 participant
@aeryz