Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ucs01): better event and generalize u128 over u256 #1907

Merged
merged 1 commit into from
May 14, 2024
Merged

fix(ucs01): better event and generalize u128 over u256 #1907

merged 1 commit into from
May 14, 2024

Conversation

hussein-aitlahcen
Copy link
Contributor

  • move from key=denom:<denom>,value=amount to key=denom,value=json_string({key=denom,value=amount}) in ucs01
  • forces token amount to be u128 accross the stack as it's the cosmos limit

fixes #1906

@hussein-aitlahcen hussein-aitlahcen force-pushed the ucs01-event-amount branch 2 times, most recently from f431e4d to 3a0fd70 Compare May 14, 2024 12:54
aeryz
aeryz previously approved these changes May 14, 2024
View reviewed changes
benluelo
benluelo previously approved these changes May 14, 2024
View reviewed changes
@hussein-aitlahcen hussein-aitlahcen dismissed stale reviews from benluelo and aeryz via 4541784 May 14, 2024 13:21
@hussein-aitlahcen hussein-aitlahcen merged commit 60db5b9 into main May 14, 2024
45 checks passed
@hussein-aitlahcen hussein-aitlahcen deleted the ucs01-event-amount branch May 14, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeryz aeryz aeryz approved these changes

@benluelo benluelo benluelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework UCS01 denom events
3 participants
@hussein-aitlahcen @aeryz @benluelo