Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cleanup IbcStateRead trait and implementations #561

Merged
merged 3 commits into from
Aug 28, 2023
Merged

feat: cleanup IbcStateRead trait and implementations #561

merged 3 commits into from
Aug 28, 2023

Conversation

benluelo
Copy link
Contributor

moved IbcStateRead to be implemented by Chains, not LightClients

@benluelo
feat: cleanup IbcStateRead trait and implementations
de0df63 
moved `IbcStateRead` to be implemented by `Chain`s, not `LightClient`s
@benluelo
chore: remove dead code
d8eeb2e
@benluelo benluelo force-pushed the ibs-state-read-cleanup branch from 9e5af77 to d8eeb2e Compare August 28, 2023 14:33
aeryz
aeryz previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@aeryz aeryz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liked this, this will make the state proofs reusable when we have 2 clients for a single chain!

@benluelo benluelo merged commit 2fb5a68 into main Aug 28, 2023
@benluelo benluelo deleted the ibs-state-read-cleanup branch August 28, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeryz aeryz aeryz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benluelo @aeryz