Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ns support mips64le arch #32

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Conversation

davidstack
Copy link
Contributor

go env info
[root@node152 weaver]# go env
GOARCH="mips64le"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOEXE=""
GOHOSTARCH="mips64le"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/root/goworkspace"
GORACE=""
GOROOT="/home/longxin/workspace/go"
GOTMPDIR=""
GOTOOLDIR="/home/longxin/workspace/go/pkg/tool/linux_mips64le"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -mabi=64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build929428261=/tmp/go-build -gno-record-gcc-switches"

go env info
[root@node152 weaver]# go env
GOARCH="mips64le"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOEXE=""
GOHOSTARCH="mips64le"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/root/goworkspace"
GORACE=""
GOROOT="/home/longxin/workspace/go"
GOTMPDIR=""
GOTOOLDIR="/home/longxin/workspace/go/pkg/tool/linux_mips64le"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -mabi=64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build929428261=/tmp/go-build -gno-record-gcc-switches"
Copy link
Contributor

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, SYS_NETNS from golang.org/x/sys/unix (which is already a dependency) could be used to replace this, i.e.

import "golang.org/x/sys/unix"
...
var SYS_SETNS = unix.SYS_SETNS

@davidstack
Copy link
Contributor Author

@tklauser ,yes,but so many go projects use vishvananda/netns, maybe this is useful to add mips64le in this project

@tklauser
Copy link
Contributor

@davidstack using unix.SETNS will also support mips64le and all other GOARCH'es supported by the golang.org/x/sys/unix package. And this without having to maintain a manual list of syscall numbers in this package.

@aboch
Copy link
Collaborator

aboch commented Jun 25, 2019

LGTM

@vishvananda vishvananda merged commit 4eab129 into vishvananda:master Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants