This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
metric for NPC errors #3794
Closed
metric for NPC errors #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to track number of errors occured during enforcing network policies Fixes #3791
murali-reddy
force-pushed
the
npc-errors-metrics
branch
from
57ca214 to
bc02cb7
Compare
bboreham
reviewed
Apr 22, 2020
| return errors.Wrap(ns.updateNetworkPolicy(oldObj, newObj), "update network policy") | ||
| }) | ||
| return err |
There was a problem hiding this comment.
Did you mean to update the metric here?
Merged
|
Replaced by #3804 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce weavenpc_policy_enforcement_errors prometheus metric to track number of errors occured during enforcing network policies
Fixes #3791