This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Reload router iptables rules if they get cleared #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foot
commented
May 13, 2020
foot
commented
May 13, 2020
bboreham
reviewed
May 14, 2020
foot
commented
May 15, 2020
|
Manual testing:
|
bboreham
reviewed
May 19, 2020
|
@bboreham PTAL at the last 2 commits when you have a moment! |
bboreham
reviewed
Jul 6, 2020
bboreham
changed the title
- Instead of EnsureBridge - Adds ipset.ExistEntry method - Refactor ipset method names Exist <-> EntryExists - Turn on iptable-refresh by default (10s) - Adds a test that checks iptables are refreshed, check EXPOSE recovers
- Should always be on. Simpler.
bboreham
approved these changes
Jul 23, 2020
- Makes it all a bit more explicit
bboreham
approved these changes
Jul 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
CANARYiptable chain and reloads all the weavenet iptable chains if theCANARYis removed by something (usuallyfirewalld).Partially addresses #3586
Details
ConfigureIPTablesand tries to make it safe to call again and again.ResetIPTablesand are called at launch so iptable state should remain mostly the same as prior to this PR.