This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Kubernetes: move kernel and CNI setup to init container #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are ancient history; reduce maintenance load by removing
bboreham
force-pushed
the
init-container
branch
2 times, most recently
from
839b2aa to
5612076
Compare
This allows the main container to run without write access to the host filesystem, except for two specific areas, thus trimming the attack surface. We lose the behaviour that the CNI plugin is only installed if Weave Net gets up and running at least once, so the error reports from kubelet will be slightly different in the case that it never manages to run.
bboreham
force-pushed
the
init-container
branch
from
5612076 to
8eeb3ca
Compare
bboreham
force-pushed
the
init-container
branch
from
9835cea to
fe61992
Compare
avestuk
pushed a commit
to avestuk/weave
that referenced
this pull request
Jan 21, 2021
Mounted as ReadOnly in order to minimize attack surface as in weaveworks#3880
avestuk
pushed a commit
to avestuk/weave
that referenced
this pull request
Jan 21, 2021
Mounted as ReadOnly in order to minimize attack surface as in weaveworks#3880
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the main container to run without write access to the host filesystem, except for two specific areas, thus trimming the attack surface.
We lose the behaviour that the CNI plugin is only installed if Weave Net gets up and running at least once, so the error reports from kubelet will be slightly different in the case that it never manages to run.
Also remove manifests for Kubernetes 1.6 and 1.7 to reduce maintenance load - they are ancient history.