Skip to content

Commit

Permalink
CI: Require pullapprove ack for protocol changes
Browse files Browse the repository at this point in the history
A change to any of the gRPC protocol buffer files (`*.proto`) should
require two additional approvals due to the potential impact it could
have across the system.

Fixes kata-containers#175.

Signed-off-by: James O. D. Hunt <[email protected]>
  • Loading branch information
jodh-intel committed Mar 19, 2018
1 parent a74147b commit 5e6c385
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,16 @@ groups:
- "*.md"
exclude:
- "vendor/*"

protocol-changes:
required: 2
teams:
- architecture-committee
- builder
- packaging
conditions:
files:
include:
- "*.proto"
exclude:
- "vendor/*"

0 comments on commit 5e6c385

Please sign in to comment.