action_sheet: Offer "Mark channel as read" in channel action sheet #1317

chimnayajith · 2025-02-02T07:16:42Z

Pull Request

Description

Adds a channel action sheet with a "Mark channel as read" option, accessible via long-press from both the inbox and subscription list pages. The action sheet is triggered by long-pressing on a channel header.

Related Issues

Closes Offer "Mark channel as read" in channel action sheet #1226

Screenshots

Additional Information

Currently the action sheet only appears in subscription list when the channel has unread messages, since the sheet doesn't have any default buttons.

chrisbobbe

Thanks! Comments below.

assets/l10n/app_en.arb

lib/widgets/action_sheet.dart

lib/widgets/inbox.dart

lib/widgets/action_sheet.dart

test/widgets/action_sheet_test.dart

chimnayajith · 2025-02-05T12:03:48Z

@chrisbobbe I’ve addressed all the requested changes. Please take a look. Thank you!

chrisbobbe

Thanks for the revision! Comments below.

lib/widgets/action_sheet.dart

lib/widgets/icons.dart

test/widgets/action_sheet_test.dart

chrisbobbe · 2025-02-05T23:22:20Z

lib/widgets/inbox.dart

+  @override
+  Future<void> onLongPress() async {
+    // TODO(#1272) action sheet for DM conversation
+    return;
+  }


bump on #1317 (comment) ; let me know if it doesn't make sense.

Couldn't figure this out. All the other changes have been pushed.

Continuing from the discussion in CZO added a commit 6791e61

I see; trying this myself, this is a little tricky. Try this change (squashed into the same commit):

diff --git lib/widgets/inbox.dart lib/widgets/inbox.dart index 551c14bdd..8c8217b6e 100644 --- lib/widgets/inbox.dart +++ lib/widgets/inbox.dart @@ -255,7 +255,6 @@ abstract class _HeaderItem extends StatelessWidget { } Future<void> onRowTap(); - Future<void> onLongPress(); @override Widget build(BuildContext context) { @@ -273,7 +272,9 @@ abstract class _HeaderItem extends StatelessWidget { // But that's in tension with the Figma, which gives these header rows // 40px min height. onTap: onCollapseButtonTap, - onLongPress: onLongPress, + onLongPress: this is _LongPressable + ? (this as _LongPressable).onLongPress + : null, child: Row(crossAxisAlignment: CrossAxisAlignment.center, children: [ Padding(padding: const EdgeInsets.all(10), child: Icon(size: 20, color: designVariables.sectionCollapseIcon, @@ -332,12 +333,6 @@ class _AllDmsHeaderItem extends _HeaderItem { pageState.allDmsCollapsed = !collapsed; } @override Future<void> onRowTap() => onCollapseButtonTap(); // TODO open all-DMs narrow? - - @override - Future<void> onLongPress() async { - // TODO(#1272) action sheet for DM conversation - return; - } } class _AllDmsSection extends StatelessWidget { @@ -439,7 +434,13 @@ class _DmItem extends StatelessWidget { } } -class _StreamHeaderItem extends _HeaderItem { +mixin _LongPressable on _HeaderItem { + // TODO(#1272) move to _HeaderItem base class + // when DM headers become long-pressable; remove mixin + Future<void> onLongPress(); +} + +class _StreamHeaderItem extends _HeaderItem with _LongPressable { final Subscription subscription; const _StreamHeaderItem({

lib/widgets/action_sheet.dart

chrisbobbe

Thanks, this is getting closer!

One tip that would be helpful for me as I review: when you use GitHub's feature for marking review comments as resolved, it makes it harder for me to go back through each one and check the new revision against it, because I have to click "show resolved" on each one. When I'm responding to a review, I like to just put a 👍 on a comment after I've addressed it, which helps me keep track without causing that problem. 🙂

Also see my reply to a question above: #1317 (comment)

chrisbobbe · 2025-02-10T22:42:39Z

lib/widgets/actions.dart

-Future<void> unregisterToken(GlobalStore globalStore, int accountId) async {
+ Future<void> unregisterToken(GlobalStore globalStore, int accountId) async {


nit: remove unwanted spacing change

chrisbobbe · 2025-02-10T22:52:07Z

lib/widgets/actions.dart

+      }
+    }
+
+    final didPass = await updateMessageFlagsStartingFromAnchor(


updateMessageFlagsStartingFromAnchor also gives UI feedback, so it also belongs in the new ZulipAction class.

chrisbobbe · 2025-02-10T23:21:59Z

lib/widgets/inbox.dart

+  @override
+  Future<void> onLongPress() async {
+    // TODO(#1272) action sheet for DM conversation
+    return;
+  }


I see; trying this myself, this is a little tricky. Try this change (squashed into the same commit):

diff --git lib/widgets/inbox.dart lib/widgets/inbox.dart index 551c14bdd..8c8217b6e 100644 --- lib/widgets/inbox.dart +++ lib/widgets/inbox.dart @@ -255,7 +255,6 @@ abstract class _HeaderItem extends StatelessWidget { } Future<void> onRowTap(); - Future<void> onLongPress(); @override Widget build(BuildContext context) { @@ -273,7 +272,9 @@ abstract class _HeaderItem extends StatelessWidget { // But that's in tension with the Figma, which gives these header rows // 40px min height. onTap: onCollapseButtonTap, - onLongPress: onLongPress, + onLongPress: this is _LongPressable + ? (this as _LongPressable).onLongPress + : null, child: Row(crossAxisAlignment: CrossAxisAlignment.center, children: [ Padding(padding: const EdgeInsets.all(10), child: Icon(size: 20, color: designVariables.sectionCollapseIcon, @@ -332,12 +333,6 @@ class _AllDmsHeaderItem extends _HeaderItem { pageState.allDmsCollapsed = !collapsed; } @override Future<void> onRowTap() => onCollapseButtonTap(); // TODO open all-DMs narrow? - - @override - Future<void> onLongPress() async { - // TODO(#1272) action sheet for DM conversation - return; - } } class _AllDmsSection extends StatelessWidget { @@ -439,7 +434,13 @@ class _DmItem extends StatelessWidget { } } -class _StreamHeaderItem extends _HeaderItem { +mixin _LongPressable on _HeaderItem { + // TODO(#1272) move to _HeaderItem base class + // when DM headers become long-pressable; remove mixin + Future<void> onLongPress(); +} + +class _StreamHeaderItem extends _HeaderItem with _LongPressable { final Subscription subscription; const _StreamHeaderItem({

chrisbobbe · 2025-02-10T23:27:00Z

lib/widgets/action_sheet.dart

+  @override
+  void onPressed() async {
+    final narrow = ChannelNarrow(streamId);
+    await ZulipAction.markNarrowAsRead(pageContext, narrow);
+  }


I see; the reasoning for ZulipAction, in its dartdoc, makes sense.

I see that ZulipAction.markNarrowAsRead takes care of giving UI feedback, so I agree a try / catch isn't needed here.

It still doesn't give one specific kind of feedback I was hoping for, though 🙂:

#1317 (comment)

Let's have special handling for if e is ZulipApiException, like other buttons that make API requests

Could you make that adjustment, in a separate commit, for both values of useLegacy? For useLegacy false, that means adjusting updateMessageFlagsStartingFromAnchor, which is where the UI-feedback code is in that case.

chrisbobbe · 2025-02-10T23:30:26Z

test/widgets/action_sheet_test.dart

+    Future<void> prepare({UnreadMessagesSnapshot? unreadMsgs}) async {
+    final stream = eg.stream();
+    someChannel = stream;
+    addTearDown(testBinding.reset);
+
+    unreadMsgs ??= eg.unreadMsgs(channels: [
+      eg.unreadChannelMsgs(
+        streamId: stream.streamId,
+        topic: 'topic',
+        unreadMessageIds: [1],
+      ),
+    ]);
+
+    await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot(
+      realmUsers: [eg.selfUser, eg.otherUser],
+      streams: [someChannel],
+      subscriptions: [eg.subscription(someChannel)],
+      unreadMsgs: unreadMsgs));
+    store = await testBinding.globalStore.perAccount(eg.selfAccount.id);
+    connection = store.connection as FakeApiConnection;
+  }


Please read through the indentation in this file and make it consistent with the project style; this part (and at least one other part) is currently hard to read.

chrisbobbe · 2025-02-10T23:34:38Z

test/widgets/action_sheet_test.dart

+    Future<void> showFromInbox(WidgetTester tester) async {
+      await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
+        child: const HomePage()));
+      await tester.pumpAndSettle();


Can we replace this with await tester.pump(); and remove the await tester.pump(); below? The 'topic action sheet' tests are doing fine that way.

chrisbobbe · 2025-02-10T23:40:01Z

test/widgets/action_sheet_test.dart

+      await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,
+        child: const SubscriptionListPageBody()));
+      await tester.pumpAndSettle();
+      check(find.byType(SubscriptionListPageBody)).findsOne();


Suggested change

await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,

child: const SubscriptionListPageBody()));

await tester.pumpAndSettle();

check(find.byType(SubscriptionListPageBody)).findsOne();

await tester.pumpWidget(TestZulipApp(accountId: eg.selfAccount.id,

child: const HomePage()));

await tester.pump();

await tester.tap(find.byIcon(ZulipIcons.hash_italic));

await tester.pump();

check(find.byType(SubscriptionListPageBody)).findsOne();

To be more representative of the real app.

chrisbobbe · 2025-02-10T23:40:22Z

test/widgets/action_sheet_test.dart

+      await tester.pumpAndSettle();
+      check(find.byType(SubscriptionListPageBody)).findsOne();
+
+      await tester.pump();


(I think this pump is unnecessary, as in showFromInbox.)

chrisbobbe · 2025-02-10T23:48:49Z

test/widgets/action_sheet_test.dart

+          connection.prepare(httpStatus: 400, json: {
+          'result': 'error', 'code': 'BAD_REQUEST', 'msg': ''});


How about, like in the topic action sheet test:

connection.prepare(exception: http.ClientException('Oops'));

which is shorter.

chrisbobbe · 2025-02-10T23:49:45Z

test/widgets/action_sheet_test.dart

+          await tester.pump(); //
+          await tester.pumpAndSettle(); // Wait for dialog animation


The await tester.pump(); // looks unnecessary, comparing with the corresponding topic action sheet test.

chimnayajith · 2025-02-11T16:10:47Z

Thanks for the review @chrisbobbe .Pushed a new revision, PTAL.

I'm a bit unsure if my revision on #1317 (comment) is correct.

chrisbobbe

Thanks for the revision!

When trying out the UI on an iPhone, I noticed some more places that we might want to offer this action sheet from, and I started a CZO discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/channel.20action.20sheet/near/2092028

I believe your next revision (for my comments below) doesn't need to be blocked on waiting for a conclusion there.

chrisbobbe · 2025-02-14T22:33:53Z

lib/widgets/actions.dart

@@ -20,6 +20,162 @@ import '../notifications/receive.dart';
 import 'dialog.dart';
 import 'store.dart';

+/// High-level operations that combine API calls with UI feedback.


actions [nfc]: Introduce ZulipAction for markNarrowAsRead & updateMessageFlagsStartingFromAnchor

commit-message nit: summary line looks too long (longer than 76 columns), and body text should be wrapped to 68 (you can configure your text editor to help with this).

chrisbobbe · 2025-02-14T22:39:22Z

lib/widgets/actions.dart

-  await updateMessageFlagsStartingFromAnchor(
+  await ZulipAction.updateMessageFlagsStartingFromAnchor(


Ah: since markNarrowAsUnreadFromMessage calls a ZulipAction method, that means it also gives UI feedback and should move to ZulipAction too.

chrisbobbe · 2025-02-14T23:00:39Z

lib/widgets/action_sheet.dart

+void showChannelActionSheet(BuildContext context, {
+  required int streamId,
+}) {


One useful change was merged after you started working on this PR 🙂: please see the top of showTopicActionSheet in main, and use PageRoot.contextOf(context) the way we do there.

chrisbobbe · 2025-02-14T23:02:18Z

lib/widgets/action_sheet.dart

@@ -163,6 +163,58 @@ class ActionSheetCancelButton extends StatelessWidget {
  }
 }

+/// Show a sheet of actions you can take on a channel.
+void showChannelActionSheet(BuildContext context, {
+  required int streamId,


Let's use the modern term channelId instead of streamId. (There are still several places in the existing code that haven't migrated yet; we'll address those separately.)

chrisbobbe · 2025-02-14T23:14:01Z

test/widgets/action_sheet_test.dart

+        checkErrorDialog(tester,
+          expectedTitle: "Mark as read failed");


Might as well also do a checkRequest here too.

chimnayajith · 2025-02-15T12:04:39Z

@chrisbobbe Pushed the revision. Please take a look.

Also implemented opening the channel action sheet from the places mentioned in the CZO discussion.

chrisbobbe · 2025-02-18T23:36:13Z

I notice that the touch target in the app bar has gotten much smaller, which will be particularly problematic for short topic or stream names. Screenshots from an iPhone simulator, using "Select widget mode" in the "Flutter inspector" tab of the Flutter dev tools:

Before	After, channel part	After, topic part

Let's have the GestureDetectors occupy all the available horizontal space:

Proposed, channel part	Proposed, topic part

To do that, I suggest:

Remove the SizedBox with width: double.infinity`
Set crossAxisAlignment: CrossAxisAlignment.stretch for the Column

Wrap _buildStreamRow and _buildTopicRow each with an Align having the appropriate alignment. Can be a new local variable:

        final alignment = willCenterTitle
          ? Alignment.center
          : AlignmentDirectional.centerStart;

So like this:

      case TopicNarrow(:var streamId, :var topic):
        final store = PerAccountStoreWidget.of(context);
        final stream = store.streams[streamId];
        final alignment = willCenterTitle
          ? Alignment.center
          : AlignmentDirectional.centerStart;
        return Column(
          crossAxisAlignment: CrossAxisAlignment.stretch,
          children: [
            GestureDetector(
              behavior: HitTestBehavior.translucent,
              onLongPress: () {
                showChannelActionSheet(context, channelId: streamId);
              },
              child: Align(alignment: alignment,
                child: _buildStreamRow(context, stream: stream)),
            ),
            GestureDetector(
              behavior: HitTestBehavior.translucent,
              onLongPress: () {
                final someMessage = MessageListPage.ancestorOf(context)
                  .model?.messages.firstOrNull;
                // If someMessage is null, the topic action sheet won't have a
                // resolve/unresolve button. That seems OK; in that case we're
                // either still fetching messages (and the user can reopen the
                // sheet after that finishes) or there aren't any messages to
                // act on anyway.
                assert(someMessage == null || narrow.containsMessage(someMessage));
                showTopicActionSheet(context,
                  channelId: streamId,
                  topic: topic,
                  someMessageIdInTopic: someMessage?.id);
              },
              child: Align(alignment: alignment,
                child: _buildTopicRow(context, stream: stream, topic: topic)))]);

chrisbobbe

Thanks! Here's the rest of a review of this revision, and see also my comment above about touch targets: #1317 (comment)

chrisbobbe · 2025-02-18T23:38:47Z

lib/widgets/message_list.dart

+        return GestureDetector(
+          behavior: HitTestBehavior.translucent,
+          onLongPress: () {
+            showChannelActionSheet(context, channelId: streamId);
+          },
+          child: _buildStreamRow(context, stream: stream),
+        );


nit: no newline before final closing ).

Also this needs test coverage.

chrisbobbe · 2025-02-18T23:39:15Z

lib/widgets/message_list.dart

+              GestureDetector(
+                behavior: HitTestBehavior.translucent,
+                onLongPress: () {
+                  showChannelActionSheet(context, channelId: streamId);
+                },
+                child: _buildStreamRow(context, stream: stream),
+              ),


Same comment about final closing ) and test coverage.

chrisbobbe · 2025-02-18T23:40:46Z

lib/widgets/message_list.dart

@@ -1083,6 +1093,7 @@ class StreamMessageRecipientHeader extends StatelessWidget {
        onTap: () => Navigator.push(context,
          MessageListPage.buildRoute(context: context,
            narrow: ChannelNarrow(message.streamId))),
+        onLongPress: () => showChannelActionSheet(context, channelId: message.streamId),


This needs test coverage.

chrisbobbe · 2025-02-18T23:45:28Z

lib/widgets/action_sheet.dart

+    optionButtons.add(
+      MarkChannelAsReadButton(
+        streamId: channelId,
+        pageContext: pageContext,
+      ),
+    );


Suggested change

optionButtons.add(

MarkChannelAsReadButton(

streamId: channelId,

pageContext: pageContext,

),

);

optionButtons.add(

MarkChannelAsReadButton(pageContext: pageContext, streamId: channelId));

(context first, and fewer lines of code)

chimnayajith · 2025-02-19T15:40:56Z

@chrisbobbe Pushed the revision. Please take a look.

chrisbobbe · 2025-02-19T22:15:33Z

It turns out that the ZulipAction class was merged separately as #1366; could you rebase past that please?

Figma doesn't specify this icon explicitly. Based on discussions in PR zulip#1274 (zulip#1274 (comment)), we chose this icon for consistency with the "Mark as read" option on web. reference: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3512-7&t=iwirdCVutQls9R0A-4

chimnayajith · 2025-02-20T00:09:18Z

I've rebased past it and pushed the updated changes. Let me know if anything else is needed!

chrisbobbe

Thanks! Small comments below.

chrisbobbe · 2025-02-20T02:47:22Z

lib/widgets/action_sheet.dart

+  final unreadCount = store.unreads.countInChannelNarrow(channelId);
+  if (unreadCount > 0) {
+    optionButtons.add(
+      MarkChannelAsReadButton(pageContext: pageContext,streamId: channelId));


nit: space after comma

chrisbobbe · 2025-02-20T23:44:13Z

lib/widgets/message_list.dart

@@ -1083,6 +1094,7 @@ class StreamMessageRecipientHeader extends StatelessWidget {
        onTap: () => Navigator.push(context,
          MessageListPage.buildRoute(context: context,
            narrow: ChannelNarrow(message.streamId))),
+        onLongPress: () => showChannelActionSheet(context, channelId: message.streamId),


I've noticed an existing bug with the gesture handling here. I filed it as #1368; no need to fix it in this PR (but feel free to claim the issue if you'd like to work on it as a followup).

chrisbobbe · 2025-02-20T23:48:47Z

test/widgets/action_sheet_test.dart

+      final effectiveChannel = channel ?? someChannel;
+      final effectiveMessages = messages ?? [someMessage];


Actually I think we can just do

Suggested change

final effectiveChannel = channel ?? someChannel;

final effectiveMessages = messages ?? [someMessage];

channel ??= someChannel;

messages ??= [someMessage];

(here and in other added tests)

See Greg's comment here: #1029 (comment)

chrisbobbe · 2025-02-20T23:54:46Z

test/widgets/action_sheet_test.dart

+        checkButtons();
+      });
+
+      testWidgets('show channel action sheet from recipient header stream row', (tester) async {


Suggested change

testWidgets('show channel action sheet from recipient header stream row', (tester) async {

testWidgets('show from recipient header', (tester) async {

I think this is clear enough from context, and is fewer words.

chrisbobbe · 2025-02-20T23:55:42Z

test/widgets/action_sheet_test.dart

+        // Prepare error response
+        connection.prepare(httpException: http.ClientException('Oops'));
+
+        // Tap and wait for dialog
+        await tester.tap(findButtonForLabel('Mark channel as read'));
+        await tester.pumpAndSettle(); // Wait for dialog animation


The code comments don't really add anything that isn't already clear; let's remove them.

Fixes: zulip#1226

chimnayajith · 2025-02-21T18:15:36Z

@chrisbobbe Pushed a revision. PTAL!

chrisbobbe · 2025-02-24T22:26:43Z

Thanks! LGTM; marking for Greg's review.

gnprice

Thanks @chimnayajith for taking this on, and @chrisbobbe for the previous reviews! Comments below.

gnprice · 2025-02-26T01:32:23Z

lib/widgets/actions.dart

      showErrorDialog(context: context,
        title: onFailedTitle,
-        message: e.toString()); // TODO(#741): extract user-facing message better
+        message: message); // TODO(#741): extract user-facing message better


nit: this comment is about the e.toString(), and should move with it

gnprice · 2025-02-26T01:40:51Z

lib/widgets/actions.dart

@@ -33,9 +34,13 @@ abstract final class ZulipAction {
        return;
      } catch (e) {
        if (!context.mounted) return;
+        final message = switch (e) {
+          ZulipApiException() => zulipLocalizations.errorServerMessage(e.message),


nit:

actions: Add specific handling for ZulipApiException in ZulipAction

"in ZulipAction" is redundant — that's an abstract final class that's just synonymous with this file

The methods are all statics and there's no such thing as an instance of ZulipAction (that's what "abstract final" means), so "in ZulipAction" wouldn't mean a whole lot anyway.

gnprice · 2025-02-26T01:42:19Z

lib/widgets/icons.dart

@@ -99,44 +99,47 @@ abstract final class ZulipIcons {
  /// The Zulip custom icon "menu".
  static const IconData menu = IconData(0xf119, fontFamily: "Zulip Icons");

+  /// The Zulip custom icon "message_checked".
+  static const IconData message_checked = IconData(0xf11a, fontFamily: "Zulip Icons");


As long as we're adding this icon, let's also make use of it in the existing piece of UI where it should appear — the mark-as-read button in the message list.

(That can be a separate commit.)

gnprice · 2025-02-26T01:44:23Z

lib/widgets/action_sheet.dart

@@ -163,6 +163,55 @@ class ActionSheetCancelButton extends StatelessWidget {
  }
 }

+/// Show a sheet of actions you can take on a channel.


The doc for showTopicActionSheet says it needs a PageRoot ancestor. From the use of PageRoot.contextOf it looks like the same is true here, so this doc should say so too.

gnprice · 2025-02-26T01:46:11Z

lib/widgets/action_sheet.dart

+    required super.pageContext
+  });
+
+  final int streamId;


nit: use the modern term "channel" when naming new things

This is a good example of something you should have been able to spot yourself, after this comment above by Chris:
#1317 (comment)

In general, when you get a piece of code-review feedback, it's important to take a bit of time to see if there are other places in the PR (or other PRs you have open) where the same point applies. That helps make the best use of reviewers' time, and helps your PR become ready to merge faster.

gnprice · 2025-02-26T02:14:59Z

test/widgets/action_sheet_test.dart

+      await testBinding.globalStore.add(eg.selfAccount, eg.initialSnapshot(
+        realmUsers: [eg.selfUser, eg.otherUser],
+        streams: [someChannel],
+        subscriptions: [eg.subscription(someChannel)],
+        unreadMsgs: unreadMsgs));
+      store = await testBinding.globalStore.perAccount(eg.selfAccount.id);


A good way to keep the test data internally consistent, in order to help keep it realistic, is to make less use of arguments to eg.initialSnapshot, and instead add add the messages, users, etc., through events. The snapshot has a lot of internal invariants that the server takes care of when producing it, and if you generate a snapshot you're responsible for upholding those, but by handling events it becomes our model code's responsibility to maintain all the invariants.

Try store.addMessage, and the other methods defined next to that one.

gnprice · 2025-02-26T02:20:09Z

test/widgets/action_sheet_test.dart

+      testWidgets('show with no unread messages', (tester) async {
+        await prepare(unreadMsgs: eg.unreadMsgs());


Similarly, this distinction of read vs. unread can be made by having an event mark the message as read, with store.handleEvent. (And see the event-making helpers in example_data.dart.)

gnprice · 2025-02-26T02:22:08Z

test/widgets/action_sheet_test.dart

+        checkErrorDialog(tester,
+          expectedTitle: "Mark as read failed");
+        checkRequest(someChannel.streamId);


nit: the request logically happens before the error dialog, so put checks in the same order

gnprice · 2025-02-26T02:25:39Z

test/widgets/action_sheet_test.dart

+        connection.prepare(json: UpdateMessageFlagsForNarrowResult(
+          processedCount: 1, updatedCount: 1,
+          firstProcessedId: null, lastProcessedId: null,


Hmm, these details don't seem logically consistent — see the doc for this endpoint:
https://zulip.com/api/update-message-flags-for-narrow
(if you go to the definition of this type and then to the endpoint that returns it, its doc links there).

These latter two fields should be null only if the range was empty. But then the other two would have to be zero.

Instead, try to pick values for these fields that are consistent with each other and with the data that's been set up in this test.

gnprice · 2025-02-26T02:27:43Z

test/widgets/action_sheet_test.dart

+        await prepare();
+        await showFromInbox(tester);
+
+        connection.prepare(httpException: http.ClientException('Oops'));
+
+        await tester.tap(findButtonForLabel('Mark channel as read'));
+        await tester.pumpAndSettle();


nit: use blank lines to group statements logically to help the reader. For test cases in particular, see:
#1183 (comment)
#1193 (comment)
#878 (comment)

Relatedly, use consistent formatting between these two contrasting tests. That helps the reader see the ways they're the same and highlight the ways they're different.

gnprice added the maintainer review PR ready for review by Zulip maintainers label Feb 4, 2025

gnprice assigned chrisbobbe Feb 4, 2025

chrisbobbe reviewed Feb 4, 2025

View reviewed changes

chimnayajith force-pushed the 1226-mark-stream-as-read branch 3 times, most recently from 0a8811a to 8a4937e Compare February 5, 2025 09:10

chrisbobbe reviewed Feb 5, 2025

View reviewed changes

chrisbobbe reviewed Feb 6, 2025

View reviewed changes

lib/widgets/action_sheet.dart Outdated Show resolved Hide resolved

chimnayajith force-pushed the 1226-mark-stream-as-read branch 4 times, most recently from 06ed689 to 93d3199 Compare February 6, 2025 16:48

chimnayajith requested a review from chrisbobbe February 6, 2025 16:52

chimnayajith force-pushed the 1226-mark-stream-as-read branch 3 times, most recently from 5768d19 to da7af54 Compare February 7, 2025 19:00

chrisbobbe reviewed Feb 10, 2025

View reviewed changes

chimnayajith force-pushed the 1226-mark-stream-as-read branch 3 times, most recently from 9b825ee to 2a5b01d Compare February 11, 2025 15:18

chrisbobbe reviewed Feb 14, 2025

View reviewed changes

chimnayajith force-pushed the 1226-mark-stream-as-read branch from 2a5b01d to e5af07a Compare February 15, 2025 10:31

chrisbobbe reviewed Feb 18, 2025

View reviewed changes

chrisbobbe mentioned this pull request Feb 19, 2025

action_sheet: Add "Mark topic as read" button #1274

Open

chimnayajith force-pushed the 1226-mark-stream-as-read branch 2 times, most recently from fe82a57 to 85bd888 Compare February 19, 2025 15:32

chimnayajith force-pushed the 1226-mark-stream-as-read branch 2 times, most recently from 04d8daa to 680f54f Compare February 19, 2025 16:38

chimnayajith added 2 commits February 20, 2025 05:28

actions: Add specific handling for ZulipApiException in ZulipAction

604b497

chimnayajith force-pushed the 1226-mark-stream-as-read branch from 680f54f to 391bc6e Compare February 20, 2025 00:01

chrisbobbe reviewed Feb 21, 2025

View reviewed changes

action_sheet: Add channel action sheet with mark as read option

622ac32

Fixes: zulip#1226

chimnayajith force-pushed the 1226-mark-stream-as-read branch from 391bc6e to 622ac32 Compare February 21, 2025 17:52

chrisbobbe assigned gnprice Feb 24, 2025

chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Feb 24, 2025

chrisbobbe requested a review from gnprice February 24, 2025 22:27

chrisbobbe removed their assignment Feb 24, 2025

gnprice reviewed Feb 26, 2025

View reviewed changes

		Future<void> unregisterToken(GlobalStore globalStore, int accountId) async {
		Future<void> unregisterToken(GlobalStore globalStore, int accountId) async {

		connection.prepare(httpStatus: 400, json: {
		'result': 'error', 'code': 'BAD_REQUEST', 'msg': ''});

		await tester.pump(); //
		await tester.pumpAndSettle(); // Wait for dialog animation

		await updateMessageFlagsStartingFromAnchor(
		await ZulipAction.updateMessageFlagsStartingFromAnchor(

		checkErrorDialog(tester,
		expectedTitle: "Mark as read failed");

		final effectiveChannel = channel ?? someChannel;
		final effectiveMessages = messages ?? [someMessage];

	testWidgets('show channel action sheet from recipient header stream row', (tester) async {
	testWidgets('show from recipient header', (tester) async {

		testWidgets('show with no unread messages', (tester) async {
		await prepare(unreadMsgs: eg.unreadMsgs());

action_sheet: Offer "Mark channel as read" in channel action sheet #1317

Are you sure you want to change the base?

action_sheet: Offer "Mark channel as read" in channel action sheet #1317

Conversation

chimnayajith commented Feb 2, 2025

Pull Request

Description

Related Issues

Screenshots

Additional Information

chrisbobbe left a comment

Choose a reason for hiding this comment

chimnayajith commented Feb 5, 2025

chrisbobbe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisbobbe left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chimnayajith commented Feb 11, 2025

chrisbobbe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chimnayajith commented Feb 15, 2025

chrisbobbe commented Feb 18, 2025

chrisbobbe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chimnayajith commented Feb 19, 2025

chrisbobbe commented Feb 19, 2025

chimnayajith commented Feb 20, 2025

chrisbobbe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chimnayajith commented Feb 21, 2025

chrisbobbe commented Feb 24, 2025

gnprice left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chrisbobbe left a comment •

edited

Loading