Add function to retrieve all attached programIDs #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pavani-Panakanti
changed the title
jayanthvn
reviewed
Feb 12, 2025
| return progId | ||
| } | ||
|
|
||
| func (m *bpfTc) GetAllAttachedProgIds() (map[string]int, map[string]int, error) { |
There was a problem hiding this comment.
Let's add a test case for this function. Can be a follow up as well but let's create an followup issue and then merge this PR.
There was a problem hiding this comment.
sounds good. I think we need to add a mock too. Will try to add, if not will create a followup
jayanthvn
approved these changes
Feb 12, 2025
|
Can you run "go mod tidy" on the test package |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Add func to get all attached prog ids
Description of changes:
Func will go through all links which have supported filters and fetch prog ID of the filter attached. It will return list of link name to attached program ID
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.