gha: also test dragonball #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's make this workflow dependent of the commit message check, and only start it if the commit message check one passes. This allows us to run this specific workflow using secrets. Signed-off-by: Fabiano Fidêncio <[email protected]>
The way previously used to get the PR's commit sha can only be used with `pull_request*` kind of events. Let's adapt it to the `workflow_run` now that we're using it. With this change we ended up dropping the PR number from the tarball suffix, as that's not straightforward to get and, to be honest, not a unique differentiator that would justify the effort. Signed-off-by: Fabiano Fidêncio <[email protected]>
As we're using the `workflow_run` event, the checkout action would pull the **current target branch** instead of the PR one. Signed-off-by: Fabiano Fidêncio <[email protected]>
FooBar ... Fixes: #0000 Signed-off-by: Fabiano Fidêncio <[email protected]>
fidencio
force-pushed
the
main
branch
4 times, most recently
from
a742113 to
13d857a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR coming from the same repo.