FC: Removed redundant RescanBlockDevice action

Firecracker has removed RescanBlockDevice from the /actions API. Related PR: firecracker-microvm/firecracker#1542. We need to remove according settings in kata-containers. Fixes: #2504 Signed-off-by: Penny Zheng <[email protected]>
kata-containers · Mar 23, 2020 · d2cae59 · d2cae59
1 parent 37b91b3
commit d2cae59
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 25 deletions.
diff --git a/virtcontainers/fc.go b/virtcontainers/fc.go
@@ -934,20 +934,6 @@ func (fc *firecracker) fcUpdateBlockDrive(path, id string) error {
 		return err
 	}
 
-	// Rescan needs to used only if the VM is running
-	if fc.vmRunning() {
-		actionParams := ops.NewCreateSyncActionParams()
-		actionType := "BlockDeviceRescan"
-		actionInfo := &models.InstanceActionInfo{
-			ActionType: &actionType,
-			Payload:    id,
-		}
-		actionParams.SetInfo(actionInfo)
-		if _, err := fc.client().Operations.CreateSyncAction(actionParams); err != nil {
-			return err
-		}
-	}
-
 	return nil
 }
 

diff --git a/virtcontainers/pkg/firecracker/client/models/instance_action_info.go b/virtcontainers/pkg/firecracker/client/models/instance_action_info.go
diff --git a/virtcontainers/pkg/firecracker/firecracker.yaml b/virtcontainers/pkg/firecracker/firecracker.yaml
@@ -449,12 +449,9 @@ definitions:
         description: Enumeration indicating what type of action is contained in the payload
         type: string
         enum:
-        - BlockDeviceRescan
         - FlushMetrics
         - InstanceStart
         - SendCtrlAltDel
-      payload:
-        type: string
 
   InstanceInfo:
     type: object