You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 12, 2021. It is now read-only.
In order to fix/implement #1059, we need to start putting all internally shared structures under an internal types package. Without doing so, breaking the code into separate packages will create circular dependencies (e.g. sandbox needs the internal store package, which needs some of the sandbox specific structures).
There is no need for moving all internal types in one go. This can be done iteratively as we move pieces of the current code into their own packages. The first big piece of this work is to move the sandbox shared structures under an internal types package.
The text was updated successfully, but these errors were encountered:
We can now remove all the sandbox shared types and convert the rest of
the code to using the new internal types package.
This commit includes virtcontainers, cli and containerd-shim changes in
one atomic change in order to not break bisect'ibility.
Fixes: kata-containers#1095
Signed-off-by: Samuel Ortiz <[email protected]>
We can now remove all the sandbox shared types and convert the rest of
the code to using the new internal types package.
This commit includes virtcontainers, cli and containerd-shim changes in
one atomic change in order to not break bisect'ibility.
Fixes: kata-containers#1095
Signed-off-by: Samuel Ortiz <[email protected]>
sameo
pushed a commit
to sameo/runtime-1
that referenced
this issue
Jan 8, 2019
We can now remove all the sandbox shared types and convert the rest of
the code to using the new internal types package.
This commit includes virtcontainers, cli and containerd-shim changes in
one atomic change in order to not break bisect'ibility.
Fixes: kata-containers#1095
Signed-off-by: Samuel Ortiz <[email protected]>
Description of problem
In order to fix/implement #1059, we need to start putting all internally shared structures under an internal
types
package. Without doing so, breaking the code into separate packages will create circular dependencies (e.g. sandbox needs the internalstore
package, which needs some of the sandbox specific structures).There is no need for moving all internal types in one go. This can be done iteratively as we move pieces of the current code into their own packages. The first big piece of this work is to move the sandbox shared structures under an internal
types
package.The text was updated successfully, but these errors were encountered: