This repository has been archived by the owner on May 12, 2021. It is now read-only.
Initial types package creation #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
3 tasks
|
Nice! lgtm Alas, the static checks have freaked out a bit over this change (see the Travis log). |
added 2 commits
January 8, 2019 14:24
Since we're going to have both external and internal types packages, we alias the external one as vcTypes. And the internal one will be usable through the types namespace. Signed-off-by: Samuel Ortiz <[email protected]>
The types package holds all shared virtcontainers types. With the separation of the virtcontainers code into separate packages, we need a types one to not create circular dependencies. This package holds sandbox related types and structures for now. It will grow as virtcontainers code is moved into their own internal packages. Signed-off-by: Samuel Ortiz <[email protected]>
Should be fixed now... |
We can now remove all the sandbox shared types and convert the rest of the code to using the new internal types package. This commit includes virtcontainers, cli and containerd-shim changes in one atomic change in order to not break bisect'ibility. Fixes: kata-containers#1095 Signed-off-by: Samuel Ortiz <[email protected]>
|
@sameo - thanks. /retest |
|
@jodh-intel I restarted the cri-containerd jenkins, it looked like a flake. |
|
Ping @kata-containers/runtime. |
egernst
approved these changes
Jan 8, 2019
|
@sboeuf , please merge if you approve the changes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types package holds all shared virtcontainers types.
With the separation of the virtcontainers code into separate packages,
we need a types one to not create circular dependencies.
This package holds sandbox related types and structures for now. It will
grow as virtcontainers code is moved into their own internal packages.
Fixes #1095