Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

wrong stop vm vs. network remove order #1956

Closed
bergwolf opened this issue Aug 13, 2019 · 0 comments · Fixed by #1957
Closed

wrong stop vm vs. network remove order #1956

bergwolf opened this issue Aug 13, 2019 · 0 comments · Fixed by #1957
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@bergwolf
Copy link
Member

Description of problem

In Sandbox.Stop(), we stop guest vm before removing network. This is wrong because in network removal, we might need to unplug network devices. And the wrong ordering can cause network removal failure and thus fail sandbox stop.

Expected result

Network removed before guest stops.

Actual result

Guest is stopped before network is removed.
@bergwolf bergwolf added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Aug 13, 2019
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Aug 13, 2019
@bergwolf
sandbox: remove network before stopping vm
794e08e 
We might need to call hypervisor hotunplug to really remove
a network device. We cannot do it after stopping the VM.

Fixes: kata-containers#1956
Signed-off-by: Peng Tao <[email protected]>
@bergwolf bergwolf mentioned this issue Aug 13, 2019
Merged
This was referenced Aug 15, 2019
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sandbox: remove network before stopping vm bergwolf/kata-runtime
1 participant
@bergwolf