This repository has been archived by the owner on May 12, 2021. It is now read-only.
sandbox: remove network before stopping vm #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might need to call hypervisor hotunplug to really remove a network device. We cannot do it after stopping the VM. Fixes: kata-containers#1956 Signed-off-by: Peng Tao <[email protected]>
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #1957 +/- ##
=======================================
Coverage 52.16% 52.16%
=======================================
Files 108 108
Lines 14227 14227
=======================================
Hits 7422 7422
Misses 5923 5923
Partials 882 882 |
devimc
approved these changes
Aug 13, 2019
egernst
approved these changes
Aug 13, 2019
This was referenced Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might need to call hypervisor hotunplug to really remove
a network device. We cannot do it after stopping the VM.
Fixes: #1956
Signed-off-by: Peng Tao [email protected]