Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

config: some variables in configuration-qemu-virtiofs.toml are not replaced with actual values #2079

Closed
chavafg opened this issue Sep 20, 2019 · 1 comment · Fixed by #2080
Closed

config: some variables in configuration-qemu-virtiofs.toml are not replaced with actual values #2079

chavafg opened this issue Sep 20, 2019 · 1 comment · Fixed by #2080
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@chavafg
Copy link
Contributor

chavafg commented Sep 20, 2019

Description of problem

# XXX: Source file: "@CONFIG_QEMU_VIRTIOFS_IN@"

.
.
.

shared_fs = "@DEFSHAREDFS_QEMU_VIRTIOFS@"
@chavafg chavafg added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Sep 20, 2019
@GabyCT
Copy link
Contributor

GabyCT commented Sep 20, 2019

@chavafg that was replaced with this PR 4134571#diff-ebce02844da8831ba833219d9a0d0d36 , it seems that you are missing something in the MAKEFILE

chavafg added a commit to chavafg/runtime-1 that referenced this issue Sep 20, 2019
@chavafg
config: honor DEFSHAREDFS_QEMU_VIRTIOFS and CONFIG_QEMU_VIRTIOFS_IN
443e657 
replace `DEFSHAREDFS_QEMU_VIRTIOFS` and `CONFIG_QEMU_VIRTIOFS_IN`
with their values on the generated `configuration-qemu-virtiofs.toml`

Fixes: kata-containers#2079

Signed-off-by: Salvador Fuentes <[email protected]>
@chavafg chavafg mentioned this issue Sep 20, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

config: honor DEFSHAREDFS_QEMU_VIRTIOFS and CONFIG_QEMU_VIRTIOFS_IN chavafg/runtime-1
2 participants
@chavafg @GabyCT