This repository has been archived by the owner on May 12, 2021. It is now read-only.
config: honor DEFSHAREDFS_QEMU_VIRTIOFS and CONFIG_QEMU_VIRTIOFS_IN #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace `DEFSHAREDFS_QEMU_VIRTIOFS` and `CONFIG_QEMU_VIRTIOFS_IN` with their values on the generated `configuration-qemu-virtiofs.toml` Fixes: kata-containers#2079 Signed-off-by: Salvador Fuentes <[email protected]>
add generated configuration file to gitignore. Signed-off-by: Salvador Fuentes <[email protected]>
virtiofsd binary built using our packaging scripts is named `virtiofsd` and not `virtiofsd-x86_64` Signed-off-by: Salvador Fuentes <[email protected]>
GabyCT
approved these changes
Sep 20, 2019
|
/test |
jcvenegas
approved these changes
Sep 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #2080 +/- ##
========================================
Coverage ? 51.6%
========================================
Files ? 108
Lines ? 14623
Branches ? 0
========================================
Hits ? 7546
Misses ? 6173
Partials ? 904 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
DEFSHAREDFS_QEMU_VIRTIOFSandCONFIG_QEMU_VIRTIOFS_INwith their values on the generated
configuration-qemu-virtiofs.tomlIn addition, add
configuration-qemu-virtio-fs.tomlto.gitignoreand fix the virtiofsd name, as the binary built using our packaging scripts
is named
virtiofsdand notvirtiofsd-x86_64Fixes: #2079