Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

virtiofsd: cache=always by default cause sync issue with host #2748

Closed
jcvenegas opened this issue Jun 5, 2020 · 0 comments · Fixed by #2749
Closed

virtiofsd: cache=always by default cause sync issue with host #2748

jcvenegas opened this issue Jun 5, 2020 · 0 comments · Fixed by #2749
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@jcvenegas
Copy link
Member

Which feature do you think can be improved?

Today for virtiofsd kata sets by default cache=always. This option is useful for performance but if the shared files are modified from the host changes are not updated in the guest as virtiofsd uses cached value all time.

We should move this value to cache=none to keep functionality and allow users to modify is want better performance results.

Related to kata-containers/tests#2572

@sboeuf @dagrh @c3d @fidencio

@jcvenegas jcvenegas added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Jun 5, 2020
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Jun 5, 2020
Today for virtiofsd kata sets by default `cache=always`. This option is
useful for performance but if the shared files are modified from the
host changes are not updated in the guest as virtiofsd uses cached value
all time.

This patch changes to  `cache=none` to have functionality. The option
can still be set to always if it is wanted by the user.

Fixes: kata-containers#2748

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Jun 5, 2020
Today for virtiofsd kata sets by default `cache=always`. This option is
useful for performance but if the shared files are modified from the
host changes are not updated in the guest as virtiofsd uses cached value
all time.

This patch changes to  `cache=none` to have functionality. The option
can still be set to always if it is wanted by the user.

Fixes: kata-containers#2748

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Jun 5, 2020
Today for virtiofsd kata sets by default `cache=always`. This option is
useful for performance but if the shared files are modified from the
host changes are not updated in the guest as virtiofsd uses cached value
all time.

This patch changes to  `cache=auto` to fix consistency issues. The option
can still be set to always if it is wanted by the user.

Fixes: kata-containers#2748

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Jun 5, 2020
Today for virtiofsd kata sets by default `cache=always`. This option is
useful for performance but if the shared files are modified from the
host changes are not updated in the guest as virtiofsd uses cached value
all time.

This patch changes to  `cache=auto` to fix consistency issues. The option
can still be set to always if it is wanted by the user.

Fixes: kata-containers#2748

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
fidencio added a commit to fidencio/kata-containers that referenced this issue Sep 8, 2020
This is a follow-up of 9177d3a, after
having the input from Vivek Goyal that the consistency issues will also
happen with `cache=auto`, but only in a lower amount.

The recommendation is to use `cache=none` as the default behavior.

Fixes: kata-containers/runtime#2748

Signed-off-by: Fabiano Fidêncio <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Oct 19, 2020
Today for virtiofsd kata sets by default `cache=always`. This option is
useful for performance but if the shared files are modified from the
host changes are not updated in the guest as virtiofsd uses cached value
all time.

This patch changes to  `cache=auto` to fix consistency issues. The option
can still be set to always if it is wanted by the user.

Fixes: kata-containers#2748

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Oct 19, 2020
Today for virtiofsd kata sets by default `cache=always`. This option is
useful for performance but if the shared files are modified from the
host changes are not updated in the guest as virtiofsd uses cached value
all time.

This patch changes to  `cache=auto` to fix consistency issues. The option
can still be set to always if it is wanted by the user.

Fixes: kata-containers#2748

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Oct 19, 2020
Today for virtiofsd kata sets by default `cache=always`. This option is
useful for performance but if the shared files are modified from the
host changes are not updated in the guest as virtiofsd uses cached value
all time.

This patch changes to  `cache=auto` to fix consistency issues. The option
can still be set to always if it is wanted by the user.

Fixes: kata-containers#2748

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Oct 20, 2020
Today for virtiofsd kata sets by default `cache=always`. This option is
useful for performance but if the shared files are modified from the
host changes are not updated in the guest as virtiofsd uses cached value
all time.

This patch changes to  `cache=auto` to fix consistency issues. The option
can still be set to always if it is wanted by the user.

Fixes: kata-containers#2748

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this issue Oct 21, 2020
Today for virtiofsd kata sets by default `cache=always`. This option is
useful for performance but if the shared files are modified from the
host changes are not updated in the guest as virtiofsd uses cached value
all time.

This patch changes to  `cache=auto` to fix consistency issues. The option
can still be set to always if it is wanted by the user.

Fixes: kata-containers#2748

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant