Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

cloud-hypervisor: kuberentes: end-to-end: Faling test #2572

Closed
jcvenegas opened this issue May 26, 2020 · 3 comments
Closed

cloud-hypervisor: kuberentes: end-to-end: Faling test #2572

jcvenegas opened this issue May 26, 2020 · 3 comments
Labels
bug Incorrect behaviour high-priority Very urgent issue (resolve quickly) needs-review Needs to be assessed by the team.

Comments

@jcvenegas
Copy link
Member

Description of problem

After enabling end-to-end test for cloud-hypervisor some test where skip.

- [Daemon set \[Serial\] should rollback without unnecessary restarts
- \[sig-storage\] Secrets optional updates should be reflected in volume \[NodeConformance\] \[Conformance\]
- \[sig-storage\] Projected secret optional updates should be reflected in volume \[NodeConformance\] \[Conformance\]
- \[sig-storage\] Projected downwardAPI should update labels on modification \[NodeConformance\] \[Conformance\]
- \[sig-storage\] Downward API volume should update annotations on modification \[NodeConformance\] \[Conformance\]
- \[sig-scheduling\] SchedulerPredicates \[Serial\] validates that there exists conflict between pods with same hostPort and protocol but one using 0.0.0.0 hostIP \[Conformance\]
- \[sig-storage\] Projected downwardAPI should update annotations on modification \[NodeConformance\] \[Conformance\]
- \[sig-storage\] Projected configMap updates should be reflected in volume \[NodeConformance\] \[Conformance\]
- \[sig-storage\] Downward API volume should update labels on modification \[NodeConformance\] \[Conformance\]
- \[sig-storage\] Projected configMap optional updates should be reflected in volume \[NodeConformance\] \[Conformance\]
- \[sig-storage\] ConfigMap optional updates should be reflected in volume \[NodeConformance\] \[Conformance\]
- \[sig-storage\] ConfigMap updates should be reflected in volume \[NodeConformance\] \[Conformance\]
@jcvenegas jcvenegas added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels May 26, 2020
@jcvenegas jcvenegas added the high-priority Very urgent issue (resolve quickly) label May 26, 2020
@jcvenegas
Copy link
Member Author

Update after some debug locally seems that sig-storage tests are because changes in shared files are not fully updated on the guest, after a some checks it is because cloud-hypervisor uses cache=always so files are cached by the virtiofsd daemon. So changes never hit the guest.

For use cases where shared is only for the provision and the host is not supposed the modify the shared files this is OK but becomes a problem for this kind of use case.

@sboeuf @dagrh any suggestion to follow here? Should be cache auto by default and document if users want more performance but this limitaiton enabled. Or we should keep using cache=always and document the limtation and how to get it working if needed.

@jcvenegas
Copy link
Member Author

As first step, I am adding the options to allow users set these values as needed.
kata-containers/runtime#2737

@sboeuf
Copy link

sboeuf commented Jun 4, 2020

@jcvenegas you should always use cache=none :)

jcvenegas added a commit to jcvenegas/kata-test that referenced this issue Jun 4, 2020
After enable virtiofsd cache=auto, all test should work.

Fixes: kata-containers#2572

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/kata-test that referenced this issue Jun 4, 2020
After enable virtiofsd cache=auto, all test should work.

Fixes: kata-containers#2572

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/kata-test that referenced this issue Jun 4, 2020
After enable virtiofsd cache=auto, all test should work.

Fixes: kata-containers#2572

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/kata-test that referenced this issue Jun 5, 2020
After enable virtiofsd cache=auto, all test should work.

Fixes: kata-containers#2572

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@chavafg chavafg closed this as completed in 3884f2f Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Incorrect behaviour high-priority Very urgent issue (resolve quickly) needs-review Needs to be assessed by the team.
Projects
None yet
Development

No branches or pull requests

2 participants