Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Add unit tests for virtcontainers/types/container.go #2856

Closed
cmaf opened this issue Jul 24, 2020 · 0 comments · Fixed by #2857
Closed

Add unit tests for virtcontainers/types/container.go #2856

cmaf opened this issue Jul 24, 2020 · 0 comments · Fixed by #2857
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.

Comments

@cmaf
Copy link
Contributor

cmaf commented Jul 24, 2020

There are no unit tests for virtcontainers/types/container.go. They can be added by adapting unit tests from sandbox.go mentioned in #2852 since they use state transitions defined in sandbox.go.
@cmaf cmaf added enhancement Improvement to an existing feature needs-review Needs to be assessed by the team. labels Jul 24, 2020
cmaf pushed a commit to cmaf/runtime that referenced this issue Jul 24, 2020
virtcontainers: Add unit test for types/container.go
71c4298 
Add unit tests for types/container.go. Tests were adapted from
sandbox_test.go since ContainerState is a sandbox state structure and
the transition tests are the same.

Fixes kata-containers#2856

Signed-off-by: Chelsea Mafrica <[email protected]>
This was referenced Jul 24, 2020
Merged
Closed
cmaf pushed a commit to cmaf/runtime that referenced this issue Jul 27, 2020
virtcontainers: Add unit test for types/container.go
35b8155 
Add unit tests for types/container.go. Tests were adapted from
sandbox_test.go since ContainerState is a sandbox state structure and
the transition tests are the same.

Fixes kata-containers#2856

Signed-off-by: Chelsea Mafrica <[email protected]>
cmaf pushed a commit to cmaf/runtime that referenced this issue Jul 29, 2020
virtcontainers: Add unit test for types/container.go
e8e1124 
Add unit tests for types/container.go. Tests were adapted from
sandbox_test.go since ContainerState is a sandbox state structure and
the transition tests are the same.

Fixes kata-containers#2856

Signed-off-by: Chelsea Mafrica <[email protected]>
@cmaf cmaf closed this as completed in #2857 Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

virtcontainers: Add unit test for types/container.go cmaf/runtime
1 participant
@cmaf