This repository has been archived by the owner on May 12, 2021. It is now read-only.
Some sandbox unit tests should be in a different directory #2852
Labels
Comments
cmaf
added
bug
cmaf
pushed a commit
to cmaf/runtime
that referenced
this issue
Jul 23, 2020
Move unit tests that were in virtcontainers/sandbox_test.go relating to Socket, Volume, and SandboxState to types/sandbox_test.go. Changed testSandboxStateTransition function to use SandboxState only instead of Sandbox from virtcontainers/sandbox.go. Fixes kata-containers#2852 Signed-off-by: Chelsea Mafrica <[email protected]>
cmaf
pushed a commit
to cmaf/runtime
that referenced
this issue
Jul 23, 2020
Move unit tests that were in virtcontainers/sandbox_test.go relating to Socket, Volume, and SandboxState to types/sandbox_test.go. Change testSandboxStateTransition function to use SandboxState only instead of Sandbox from virtcontainers/sandbox.go. Fixes kata-containers#2852 Signed-off-by: Chelsea Mafrica <[email protected]>
cmaf
pushed a commit
to cmaf/runtime
that referenced
this issue
Jul 24, 2020
Move unit tests that were in virtcontainers/sandbox_test.go relating to Socket, Volume, and SandboxState to types/sandbox_test.go. Change testSandboxStateTransition function to use SandboxState only instead of Sandbox from virtcontainers/sandbox.go. Fixes kata-containers#2852 Signed-off-by: Chelsea Mafrica <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The unit tests for virtcontainers/types/sandbox.go are in the parent directory instead of in virtcontainers/types, making it appear as if there is no coverage for functions in sandbox. Move tests related to
Socket,Volume, andSandboxStatetotypesdirectory.Issue for 2.x is #435
The text was updated successfully, but these errors were encountered: