This repository has been archived by the owner on May 12, 2021. It is now read-only.
virtcontainers: Move unit tests for types/sandbox.go #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for raising your pull request. Please note that the main development of Kata Containers has moved to the 2.0-dev branch of https://github.com/kata-containers/kata-containers repository. The kata-containers/runtime repository is kept for 1.x release maintenance. Please check twice if your change should go to the 2.0-dev branch directly. If it is strongly required for adding the change to Kata Containers 1.x releases, please ping @kata-containers/runtime to assign a dedicated developer to be responsible for porting the change to 2.0-dev branch. Thanks! |
cmaf
force-pushed
the
unittest-virtcontainers-sandbox
branch
from
947b5e0 to
c05cf81
Compare
|
/test-ubuntu |
added 2 commits
July 24, 2020 00:11
Move unit tests that were in virtcontainers/sandbox_test.go relating to Socket, Volume, and SandboxState to types/sandbox_test.go. Change testSandboxStateTransition function to use SandboxState only instead of Sandbox from virtcontainers/sandbox.go. Fixes kata-containers#2852 Signed-off-by: Chelsea Mafrica <[email protected]>
Remove tests from virtcontainers/sandbox_test.go which were moved to virtcontainers/types/sandbox_test.go. Signed-off-by: Chelsea Mafrica <[email protected]>
cmaf
force-pushed
the
unittest-virtcontainers-sandbox
branch
from
c05cf81 to
345d0c2
Compare
|
/test-ubuntu |
Codecov Report
@@ Coverage Diff @@
## master #2853 +/- ##
==========================================
+ Coverage 50.62% 51.05% +0.43%
==========================================
Files 118 118
Lines 17367 17367
==========================================
+ Hits 8792 8867 +75
+ Misses 7497 7422 -75
Partials 1078 1078 |
Add tests for state change, empty string failures for Volumes and Sockets. Change two function names to accurately reflect tests. Signed-off-by: Chelsea Mafrica <[email protected]>
cmaf
added
needs-review
|
/test-ubuntu |
amshinde
approved these changes
Jul 24, 2020
|
Forward port: kata-containers/kata-containers#450 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move unit tests that were in virtcontainers/sandbox_test.go relating to Socket, Volume, and SandboxState to types/sandbox_test.go.
Changed testSandboxStateTransition function to use SandboxState only instead of Sandbox from virtcontainers/sandbox.go.
Fixes #2852
Signed-off-by: Chelsea Mafrica [email protected]