This repository has been archived by the owner on May 12, 2021. It is now read-only.
cpuset: fixes to address VM sizing and constraining based on cpuset.mems #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPUSet cgroup allows for pinning the memory associated with a cpuset to a given numa node. Similar to cpuset.cpus, we should take cpuset.mems into account for the sandbox-cgroup that Kata creates. Fixes: kata-containers#2970 Signed-off-by: Eric Ernst <[email protected]>
|
/test |
|
@egernst, please take a look: And a general comment, we're now mixing cpu and memory sets / getters. Wouldn't be better to have one function for each one of those, as we already do in the sandbox level? |
Hmm. No, thinking a little bit more about this, no. It's specfically related to cpuset. So, please, ignore my previous suggestion. |
egernst
force-pushed
the
cpuset-fixes
branch
from
04c96b4 to
479fd70
Compare
|
/test |
egernst
force-pushed
the
cpuset-fixes
branch
from
479fd70 to
a7b019d
Compare
|
/test |
egernst
force-pushed
the
cpuset-fixes
branch
from
a7b019d to
7788cb7
Compare
|
(sorry to keep thrashing the CI). /test |
egernst
force-pushed
the
cpuset-fixes
branch
from
7788cb7 to
f49d6fc
Compare
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2972 +/- ##
==========================================
- Coverage 51.65% 45.17% -6.49%
==========================================
Files 118 118
Lines 17430 15565 -1865
==========================================
- Hits 9003 7031 -1972
- Misses 7342 7667 +325
+ Partials 1085 867 -218 |
If quota is not being enforced on any containers but CPUsets are specified, take the number of CPU sets into account when sizing the virtual machine. Fixes: kata-containers#2971 Signed-off-by: Eric Ernst <[email protected]>
egernst
force-pushed
the
cpuset-fixes
branch
from
f49d6fc to
8ef2946
Compare
|
/test |
jodh-intel
approved these changes
Sep 22, 2020
|
/test metrics-ubuntu |
devimc
approved these changes
Sep 25, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a given numa node. Similar to cpuset.cpus, we should take cpuset.mems
into account for the sandbox-cgroup that Kata creates.
specified, take the number of CPU sets into account when sizing the
virtual machine.