This repository has been archived by the owner on May 12, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamwhaley
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
- agent: change 9pfs mount option to cache=mmap - vc: qemu: Add config option to choose entropy source. - virtcontainers: revert "fix shared dir resource remaining" - block: Fix how rootfs is passed to kata-agent using virtio-blk - agent: clean up proxy process if start sandbox failed - config: Add Memory slots config - virtcontainers: support vhost and physical endpoints in AddInterface - device: Add GPU device support - virtcontainers: fix the issue of missing starting builtin proxy - Cleanup template properly - cli: add systemd-cgroup option - netmon: Add signals handler support - versions: update containerd version - scripts: Add throttler details to collect script - virtcontainers: hotplug memory with kata-runtime update command. - factory: start proxy before assign vm to a sandbox - virtcontainers: netmon: Monitor network changes - versions: Bump golang from 1.8.3 to 1.9.7 - cli: add configuration option to enable/disable vhost_net 41619e4 vc: qemu: Add option to change entropy source 9e606b3 virtcontainers: revert "fix shared dir resource remaining" 58cf7fc block: Fix how rootfs is passed to kata-agent using virtio-blk ec87dca virtcontainers: support vhost and physical endpoints in AddInterface 19801bf config: Add Memory slots configuration. bb513a7 agent: change 9pfs mount option to cache=mmap 0ddf99d agent: clean up proxy process if start sandbox failed 5612694 virtcontainers: fix the issue of missing starting builtin proxy 67ffa2f factory: close factory in UT b193f0f template: clean up template mountpoint on failures 37b83c8 device: Add GPU device support 2216d52 vendor: Update govmm to add vfio mediated device support on root bus 048616f netmon: Add signals handler 1675410 pkg: signals: Factorize signals handling through a Go package 723fbac versions: update containerd version 0075175 cli: add systemd-cgroup option 6fc13e9 scripts: Add throttler details to collect script 12a0354 sandbox: get and store guest details. 13bf7d1 virtcontainers: hotplug memory with kata-runtime update command 0928519 vendor: update agent to support memory update 0ffe81c cli: config: Make netmon configurable 1406d99 virtcontainers: Start network monitor from virtcontainers 29e2fa0 virtcontainers: Avoid conflict with network monitor f6ce465 vendor: Update agent vendoring 55af108 netmon: Add unit testing f131590 netmon: Build netmon from the master Makefile fca7435 netmon: Add logrus support bbf2a47 netmon: Don't rely on agent protocol b708a4a netmon: Monitor network changes d75841e ut: add more UTs 07c1f18 factory: start proxy after create new VM 4738d4e agent: add setProxy/getAgentURL interface 8f77c33 proxy: decouple from sandbox f39fa5d proxy: remove newProxyConfig c41c9de proxy: do not decode proxy config 225e10c cli: add configuration option to enable/disable vhost_net 5ebb7cf vendor: Update govmm to disable vhost when host doesn't support vhost-net d814bc5 versions: Bump golang from 1.8.3 to 1.9.7 Signed-off-by: Peng Tao <[email protected]>
ff6aec1
to
7078d3b
Compare
sboeuf
approved these changes
Sep 26, 2018
/test |
egernst
approved these changes
Sep 26, 2018
kicked the centos CI (network timeout). |
PSS Measurement: Memory inside container: |
Codecov Report
@@ Coverage Diff @@
## master #789 +/- ##
=======================================
Coverage 65.32% 65.32%
=======================================
Files 87 87
Lines 10619 10619
=======================================
Hits 6937 6937
Misses 2985 2985
Partials 697 697 |
egernst
pushed a commit
to egernst/runtime
that referenced
this pull request
Feb 9, 2021
In case the 'Id' (a.k.a 'PCIAdrr') field is not set for the input block device, we reply on the predicted 'VmPath' set by the kata-runtime to locate the blk device in the guest. Fixes: kata-containers#789 Signed-off-by: Bo Chen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
41619e4 vc: qemu: Add option to change entropy source
9e606b3 virtcontainers: revert "fix shared dir resource remaining"
58cf7fc block: Fix how rootfs is passed to kata-agent using virtio-blk
ec87dca virtcontainers: support vhost and physical endpoints in AddInterface
19801bf config: Add Memory slots configuration.
bb513a7 agent: change 9pfs mount option to cache=mmap
0ddf99d agent: clean up proxy process if start sandbox failed
5612694 virtcontainers: fix the issue of missing starting builtin proxy
67ffa2f factory: close factory in UT
b193f0f template: clean up template mountpoint on failures
37b83c8 device: Add GPU device support
2216d52 vendor: Update govmm to add vfio mediated device support on root bus
048616f netmon: Add signals handler
1675410 pkg: signals: Factorize signals handling through a Go package
723fbac versions: update containerd version
0075175 cli: add systemd-cgroup option
6fc13e9 scripts: Add throttler details to collect script
12a0354 sandbox: get and store guest details.
13bf7d1 virtcontainers: hotplug memory with kata-runtime update command
0928519 vendor: update agent to support memory update
0ffe81c cli: config: Make netmon configurable
1406d99 virtcontainers: Start network monitor from virtcontainers
29e2fa0 virtcontainers: Avoid conflict with network monitor
f6ce465 vendor: Update agent vendoring
55af108 netmon: Add unit testing
f131590 netmon: Build netmon from the master Makefile
fca7435 netmon: Add logrus support
bbf2a47 netmon: Don't rely on agent protocol
b708a4a netmon: Monitor network changes
d75841e ut: add more UTs
07c1f18 factory: start proxy after create new VM
4738d4e agent: add setProxy/getAgentURL interface
8f77c33 proxy: decouple from sandbox
f39fa5d proxy: remove newProxyConfig
c41c9de proxy: do not decode proxy config
225e10c cli: add configuration option to enable/disable vhost_net
5ebb7cf vendor: Update govmm to disable vhost when host doesn't support vhost-net
d814bc5 versions: Bump golang from 1.8.3 to 1.9.7