This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
integration: update cpuset tests #2846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egernst
force-pushed
the
cpuset-updates
branch
from
3c032f1 to
f5cdc7b
Compare
|
/test |
egernst
added a commit
to egernst/runtime
that referenced
this pull request
Sep 10, 2020
Kata doesn't map any numa topologies in the guest. Let's make sure we clear the Cpuset fields before passing container updates to the guest. Without this, we could encounter a runtime failure: ``` process_linux.go:297: applying cgroup configuration for process caused "failed to write 0,1 to cpuset.mems: writea 0,1 to cpuset.mems: write 0,1 to cpuset.mems: write /sys/fs/cgroup/cpuset .... /cpuset.mems: numerical result out of range"": unknown ``` Note, in the future we may want to have a vCPU to guest CPU mapping and still include the cpuset.Cpus. Until we have this support, clear this as well. Fixes: kata-containers#2176 Depends-on: github.com/kata-containers/tests#2846 Signed-off-by: Eric Ernst <[email protected]>
The minimum number of CPUs were wrong. sum of cpus in set 0,2 is 2, not 3. sum of cpus in set 0,3 is 2, not 3. Fixes: kata-containers#2845 Signed-off-by: Eric Ernst <[email protected]>
egernst
force-pushed
the
cpuset-updates
branch
from
f5cdc7b to
02a87e1
Compare
|
/test |
|
/test |
egernst
force-pushed
the
cpuset-updates
branch
2 times, most recently
from
94741c6 to
a8addb5
Compare
This test will fail until we have appropriate CPUSet support inside the guest. Today CPUSets are only supported on the host, and are done by placing the entire guest into a CPUset that matches the sum of container cpusets. This isn't reflected via nproc in the guest. - Remove test that checked nproc - Update cpu test to check host cpuset cgroup Fixes: kata-containers#2845 Signed-off-by: Eric Ernst <[email protected]>
egernst
force-pushed
the
cpuset-updates
branch
from
a8addb5 to
d0b76d1
Compare
|
/test |
|
@egernst - thanks. Does this also need raising in the |
|
Yes, @jodh-intel |
devimc
approved these changes
Sep 11, 2020
|
@egernst, my understanding is that we will also need this one backported to the stable-1.11 branch. |
fidencio
added
backport
fidencio
pushed a commit
to fidencio/kata-runtime
that referenced
this pull request
Sep 11, 2020
Kata doesn't map any numa topologies in the guest. Let's make sure we clear the Cpuset fields before passing container updates to the guest. Without this, we could encounter a runtime failure: ``` process_linux.go:297: applying cgroup configuration for process caused "failed to write 0,1 to cpuset.mems: writea 0,1 to cpuset.mems: write 0,1 to cpuset.mems: write /sys/fs/cgroup/cpuset .... /cpuset.mems: numerical result out of range"": unknown ``` Note, in the future we may want to have a vCPU to guest CPU mapping and still include the cpuset.Cpus. Until we have this support, clear this as well. Fixes: kata-containers#2176 Depends-on: github.com/kata-containers/tests#2846 Signed-off-by: Eric Ernst <[email protected]>
chavafg
pushed a commit
to chavafg/runtime-1
that referenced
this pull request
Oct 16, 2020
Kata doesn't map any numa topologies in the guest. Let's make sure we clear the Cpuset fields before passing container updates to the guest. Without this, we could encounter a runtime failure: ``` process_linux.go:297: applying cgroup configuration for process caused "failed to write 0,1 to cpuset.mems: writea 0,1 to cpuset.mems: write 0,1 to cpuset.mems: write /sys/fs/cgroup/cpuset .... /cpuset.mems: numerical result out of range"": unknown ``` Note, in the future we may want to have a vCPU to guest CPU mapping and still include the cpuset.Cpus. Until we have this support, clear this as well. Fixes: kata-containers#2176 Depends-on: github.com/kata-containers/tests#2846 Signed-off-by: Eric Ernst <[email protected]> (cherry picked from commit b5b8870)
jcvenegas
pushed a commit
to jcvenegas/runtime
that referenced
this pull request
Oct 19, 2020
Kata doesn't map any numa topologies in the guest. Let's make sure we clear the Cpuset fields before passing container updates to the guest. Without this, we could encounter a runtime failure: ``` process_linux.go:297: applying cgroup configuration for process caused "failed to write 0,1 to cpuset.mems: writea 0,1 to cpuset.mems: write 0,1 to cpuset.mems: write /sys/fs/cgroup/cpuset .... /cpuset.mems: numerical result out of range"": unknown ``` Note, in the future we may want to have a vCPU to guest CPU mapping and still include the cpuset.Cpus. Until we have this support, clear this as well. Fixes: kata-containers#2176 Depends-on: github.com/kata-containers/tests#2846 Signed-off-by: Eric Ernst <[email protected]>
jcvenegas
pushed a commit
to jcvenegas/runtime
that referenced
this pull request
Oct 19, 2020
Kata doesn't map any numa topologies in the guest. Let's make sure we clear the Cpuset fields before passing container updates to the guest. Without this, we could encounter a runtime failure: ``` process_linux.go:297: applying cgroup configuration for process caused "failed to write 0,1 to cpuset.mems: writea 0,1 to cpuset.mems: write 0,1 to cpuset.mems: write /sys/fs/cgroup/cpuset .... /cpuset.mems: numerical result out of range"": unknown ``` Note, in the future we may want to have a vCPU to guest CPU mapping and still include the cpuset.Cpus. Until we have this support, clear this as well. Fixes: kata-containers#2176 Depends-on: github.com/kata-containers/tests#2846 Signed-off-by: Eric Ernst <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove cpuset test