Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

metrics: Update the expected midval for CI jobs using virtio-fs #2924

Merged

Conversation

likebreath
Copy link
Contributor

Disabling the DAX option of virtio-fsd has direct impact to the memory
foot-print and I/O performance. We need to adjust the expected midval
for our metrics CI jobs on cloud-hypervisor and qemu with virtiofs.

Depends-on: github.com/kata-containers/runtime#2997

Fixes: #2923

Signed-off-by: Bo Chen [email protected]

Disabling the DAX option of `virtio-fsd` has direct impact to the memory
foot-print and I/O performance. We need to adjust the expected `midval`
for our metrics CI jobs on `cloud-hypervisor` and `qemu with virtiofs`.

Depends-on: github.com/kata-containers/runtime#2997

Fixes: kata-containers#2923

Signed-off-by: Bo Chen <[email protected]>
@likebreath
Copy link
Contributor Author

/test-ubuntu-metrics
/test-clh-metrics

@likebreath
Copy link
Contributor Author

/test-ubuntu

@likebreath likebreath added no-backport-needed Changed do not need to be applied to an older branch / repository no-forward-port-needed Changed do not need to be applied to a newer branch / repository labels Oct 6, 2020
@likebreath
Copy link
Contributor Author

The update reference data is based on multiple runs of the metrics CI in kata-runtime.

The data for qemu-virtiofs-metrics is from here (job 96-99). The collected data is as following:

Memory foot-print MF-KSM Blogbench-write
136614.48 134322.52 1419
136674.55 134375.78 1475
136785.74 134414.96 1475
136691.59 134371.0867 1456.333
153075.3* 150763.2* 1103*

*Note: the last row is clearly an outlier comparing with other data (log), and hence I did not include it when computing the average midval. In this way, we can keep our allowed range as +/-5% (instead of +/- 10%).

The data for clh-metrics is from here (job 134-138). The collected data is as following:

Memory foot-print MF-KSM Blogbench-write Blogbench - read
272571.1 272537.7 1157 49972
272604.6 272533.45 1176 48592
272555.4 272529.55 1132 47771
272615.9 272586.25 1180 49108

/cc @GabyCT @jcvenegas

@likebreath
Copy link
Contributor Author

/test-metrics-virtiofs

@likebreath
Copy link
Contributor Author

likebreath commented Oct 7, 2020

The updated number looks to be working fine. I run the metrics CI for both clh (CI job 136-138) and qemu-virtiofs (CI job 70-72) 3 times each, and they were all passing.

@likebreath
Copy link
Contributor Author

In general, both for clh and qemu-virtiofsd (non-KSM and KSM), the memory footprint reduced around ~6%. One more dramatic change is for clh's metrics on the blogbench, where the write performance reduced by 70% (from 3927.30 to 1161.25) while the read performance booted 4.25X (from 11488.28 to 48860.75).

@jcvenegas Can you please take a look at the updated numbers, and see whether that aligns with your observations from your experiments on virtiofsd?

/cc @GabyCT @amshinde @chavafg

@jcvenegas jcvenegas added the do-not-merge PR has problems or depends on another label Oct 7, 2020
jcvenegas added a commit to jcvenegas/runtime that referenced this pull request Oct 8, 2020
virtiofs DAX support is not stable today, there are
a few corner cases to make it default.

Depends-on: github.com/kata-containers/tests#2924

Fixes: kata-containers#2999

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
@likebreath likebreath removed the do-not-merge PR has problems or depends on another label Oct 8, 2020
@likebreath
Copy link
Contributor Author

Remove the DNM to land it along with the other PR in runtime: kata-containers/runtime#2997.

@likebreath likebreath merged commit 03fb529 into kata-containers:master Oct 8, 2020
jcvenegas added a commit to jcvenegas/runtime that referenced this pull request Oct 19, 2020
virtiofs DAX support is not stable today, there are
a few corner cases to make it default.

Depends-on: github.com/kata-containers/tests#2924

Fixes: kata-containers#2999

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this pull request Oct 19, 2020
virtiofs DAX support is not stable today, there are
a few corner cases to make it default.

Depends-on: github.com/kata-containers/tests#2924

Fixes: kata-containers#2999

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this pull request Oct 19, 2020
virtiofs DAX support is not stable today, there are
a few corner cases to make it default.

Depends-on: github.com/kata-containers/tests#2924

Fixes: kata-containers#2999

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
jcvenegas added a commit to jcvenegas/runtime that referenced this pull request Oct 20, 2020
virtiofs DAX support is not stable today, there are
a few corner cases to make it default.

Depends-on: github.com/kata-containers/tests#2924

Fixes: kata-containers#2999

Signed-off-by: Jose Carlos Venegas Munoz <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-backport-needed Changed do not need to be applied to an older branch / repository no-forward-port-needed Changed do not need to be applied to a newer branch / repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics: update the expected midval as we are disabling the DAX option of virtiofs
4 participants