fix(818): add sd environment to env var #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkyi
reviewed
May 12, 2020
config/pod.yaml.hbs
Outdated
| @@ -30,6 +30,8 @@ spec: | |||
| value: {{container}} | |||
| - name: SD_PIPELINE_ID | |||
| value: "{{pipeline_id}}" | |||
| - name: SD_ENVIRONMENT | |||
There was a problem hiding this comment.
personally, that VAR name is kind of confusing/misleading to me
not sure if something like SD_CLUSTER or SD_CLUSTER_PREFIX would make more sense
There was a problem hiding this comment.
SD_CLUSTER is referred here - https://github.com/screwdriver-cd/screwdriver/blob/master/config/custom-environment-variables.yaml#L359. how about SD_PREFIX?
There was a problem hiding this comment.
updated to SD_BUILD_PREFIX
vnugopal
approved these changes
May 12, 2020
tkyi
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
pipeline-id/job-id/build-id is available in both beta and prod environments, which results in incorrect metrics.
Objective
Add sd environment to metrics data.
References
feat(818): Evaluate Kata Containers over HyperD
Launcher PR-352
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.