Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(818): add sd environment to env var #126

Merged
merged 2 commits into from
May 12, 2020
Merged

fix(818): add sd environment to env var #126

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
302f3c8
fix(818): add sd environment to env var
May 11, 2020
ca3feb9
fix(818): upd var name
May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/pod.yaml.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ spec:
value: {{container}}
- name: SD_PIPELINE_ID
value: "{{pipeline_id}}"
- name: SD_ENVIRONMENT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally, that VAR name is kind of confusing/misleading to me
not sure if something like SD_CLUSTER or SD_CLUSTER_PREFIX would make more sense

Copy link
Contributor Author

@parthasl parthasl May 12, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SD_CLUSTER is referred here - https://github.com/screwdriver-cd/screwdriver/blob/master/config/custom-environment-variables.yaml#L359. how about SD_PREFIX?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to SD_BUILD_PREFIX

value: "{{prefix}}"
- name: NODE_ID
valueFrom:
fieldRef:
Expand Down
1 change: 1 addition & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,7 @@ class K8sExecutor extends Executor {
pod_name: `${buildContainerName}-${random}`,
privileged: this.privileged,
build_id_with_prefix: buildContainerName,
prefix: this.prefix,
build_id: buildId,
job_id: jobId,
pipeline_id: pipelineId,
Expand Down