Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

master build failure #2213

Closed
bergwolf opened this issue Nov 19, 2019 · 0 comments · Fixed by #2214
Closed

master build failure #2213

bergwolf opened this issue Nov 19, 2019 · 0 comments · Fixed by #2214
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.

Comments

@bergwolf
Copy link
Member

Description of problem

After merging #2202
master build fails:

     BUILD    /home/vagrant/workplace/golang/src/github.com/kata-containers/runtime/kata-runtime
# github.com/kata-containers/runtime/virtcontainers
../virtcontainers/hypervisor.go:197:10: cannot use &cloudHypervisor literal (type *cloudHypervisor) as type hypervisor in return argument:
        *cloudHypervisor does not implement hypervisor (wrong type for createSandbox method)
                have createSandbox("context".Context, string, NetworkNamespace, *HypervisorConfig, *store.VCStore) error
                want createSandbox("context".Context, string, NetworkNamespace, *HypervisorConfig, *store.VCStore, bool) error
Makefile:528: recipe for target '/home/vagrant/workplace/golang/src/github.com/kata-containers/runtime/kata-runtime' failed
@bergwolf bergwolf added bug Incorrect behaviour needs-review Needs to be assessed by the team. labels Nov 19, 2019
bergwolf added a commit to bergwolf/kata-runtime that referenced this issue Nov 19, 2019
@bergwolf
clh: fix build
510f0a6 
PR kata-containers#2202 changed createSandbox() interface but didn't get a chance
to match with cloud hypervisor change.

Fixes: kata-containers#2213

Signed-off-by: Peng Tao <[email protected]>
@bergwolf bergwolf mentioned this issue Nov 19, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Incorrect behaviour needs-review Needs to be assessed by the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

clh: fix build bergwolf/kata-runtime
1 participant
@bergwolf