This repository has been archived by the owner on May 12, 2021. It is now read-only.
FC: log out the firecracker's console when debug enabled #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifupan
force-pushed
the
watch_firecracker_console
branch
2 times, most recently
from
07a746b to
3f14ea1
Compare
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2202 +/- ##
=========================================
Coverage ? 51.12%
=========================================
Files ? 110
Lines ? 15152
Branches ? 0
=========================================
Hits ? 7747
Misses ? 6448
Partials ? 957 |
Add a 'sateful' variable to FC to indicate when it is called with cli or shimv2. Signed-off-by: lifupan <[email protected]>
For shimv2 case, when hypervisor's debug option set, log out the firecracker's console output which contains the kernel boot logs; thus it would be easy for system panic debugging. When agent debug was enabled by passing "agent.log=debug" to kernel parameter, it will also log out the agent logs from the console output. Fixes: kata-containers#2201 Signed-off-by: lifupan <[email protected]>
lifupan
force-pushed
the
watch_firecracker_console
branch
from
3f14ea1 to
a2b6afc
Compare
|
/test |
devimc
approved these changes
Nov 15, 2019
|
ping @kata-containers/runtime |
bergwolf
approved these changes
Nov 19, 2019
Closed
bergwolf
added a commit
to bergwolf/kata-runtime
that referenced
this pull request
Nov 19, 2019
PR kata-containers#2202 changed createSandbox() interface but didn't get a chance to match with cloud hypervisor change. Fixes: kata-containers#2213 Signed-off-by: Peng Tao <[email protected]>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When hypervisor's debug option set, log out the firecracker's
console output which contains the kernel boot logs; thus it
would be easy for system panic debugging.
When agent debug was enabled by passing "agent.log=debug" to
kernel parameter, it will also log out the agent logs from
the console output.
Fixes: #2201
Signed-off-by: lifupan [email protected]