Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

clh: fix build #2214

Merged
merged 1 commit into from
Nov 19, 2019
Merged

clh: fix build #2214

merged 1 commit into from
Nov 19, 2019

Conversation

bergwolf
Copy link
Member

PR #2202 changed createSandbox() interface but didn't get a chance
to match with cloud hypervisor change.

Fixes: #2213

This just fixes build. Actual support for debug log on cloud hypervisor should be added later.

PR kata-containers#2202 changed createSandbox() interface but didn't get a chance
to match with cloud hypervisor change.

Fixes: kata-containers#2213

Signed-off-by: Peng Tao <[email protected]>
@bergwolf
Copy link
Member Author

/test

Copy link
Member

@WeiZhang555 WeiZhang555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM definitely

Copy link
Contributor

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bergwolf !

lgtm

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@be6110d). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #2214   +/-   ##
=========================================
  Coverage          ?   48.77%           
=========================================
  Files             ?      111           
  Lines             ?    15981           
  Branches          ?        0           
=========================================
  Hits              ?     7794           
  Misses            ?     7222           
  Partials          ?      965

@WeiZhang555 WeiZhang555 merged commit c0d2867 into kata-containers:master Nov 19, 2019
@bergwolf bergwolf deleted the fix-build branch December 10, 2019 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

master build failure
4 participants