Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Fix kata-env on amd64 #660

Closed
jodh-intel opened this issue Aug 29, 2018 · 0 comments
Closed

Fix kata-env on amd64 #660

jodh-intel opened this issue Aug 29, 2018 · 0 comments
Assignees

Comments

@jodh-intel
Copy link
Contributor

As we noticed on #646, kata-env is incorrectly reporting true on systems where virtualisation support is not available (however, kata-check works correctly).

@jodh-intel jodh-intel self-assigned this Aug 29, 2018
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Aug 29, 2018
Fix nasty bug which resulted in `kata-env` showing
`VMContainerCapable = true` even on amd64 systems without virtualisation
support (thankfully `kata-check` still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes kata-containers#660.

Signed-off-by: James O. D. Hunt <[email protected]>
@egernst egernst added the review label Aug 29, 2018
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Aug 29, 2018
Fix nasty bug which resulted in `kata-env` showing
`VMContainerCapable = true` even on amd64 systems without virtualisation
support (thankfully `kata-check` still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes kata-containers#660.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Aug 29, 2018
Fix nasty bug which resulted in `kata-env` showing
`VMContainerCapable = true` even on amd64 systems without virtualisation
support (thankfully `kata-check` still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes kata-containers#660.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Aug 29, 2018
Fix nasty bug which resulted in `kata-env` showing
`VMContainerCapable = true` even on amd64 systems without virtualisation
support (thankfully `kata-check` still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes kata-containers#660.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Aug 29, 2018
Fix nasty bug which resulted in `kata-env` showing
`VMContainerCapable = true` even on amd64 systems without virtualisation
support (thankfully `kata-check` still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes kata-containers#660.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Aug 30, 2018
Fix nasty bug which resulted in `kata-env` showing
`VMContainerCapable = true` even on amd64 systems without virtualisation
support (thankfully `kata-check` still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes kata-containers#660.

Signed-off-by: James O. D. Hunt <[email protected]>
@egernst egernst removed the review label Aug 30, 2018
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Sep 13, 2018
Fix nasty bug which resulted in `kata-env` showing
`VMContainerCapable = true` even on amd64 systems without virtualisation
support (thankfully `kata-check` still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes kata-containers#660.

Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel added a commit to jodh-intel/runtimes that referenced this issue Sep 13, 2018
Fix nasty bug which resulted in `kata-env` showing
`VMContainerCapable = true` even on amd64 systems without virtualisation
support (thankfully `kata-check` still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes kata-containers#660.

Signed-off-by: James O. D. Hunt <[email protected]>
lifupan pushed a commit to hyperhq/kata-runtime that referenced this issue Sep 17, 2018
Fix nasty bug which resulted in `kata-env` showing
`VMContainerCapable = true` even on amd64 systems without virtualisation
support (thankfully `kata-check` still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes kata-containers#660.

Signed-off-by: James O. D. Hunt <[email protected]>
egernst pushed a commit to egernst/runtime that referenced this issue Feb 9, 2021
client: remove the parameter of 'enableYamux'
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants