kata-env: Fix amd64 VM container capable check #661
Conversation
|
PSS Measurement: Memory inside container: |
|
The builds are failing.... BTW why not just add support for all architectures at once? That seems easier. For Z i need "vx" feature to be available. I have aliased features to flag on x86 so so may test the same way you do for x86. @nitkon What do you require for Power? |
|
Build failed (third-party-check pipeline) integration testing with
|
jodh-intel
force-pushed
the
fix-amd64-kata-env
branch
from
4556068 to
533f4f0
Compare
|
PSS Measurement: Memory inside container: |
jodh-intel
force-pushed
the
fix-amd64-kata-env
branch
from
533f4f0 to
b245cbe
Compare
|
Hi @ydjainopensource - the bug was specific to amd64. However, I've now added tests for the other architectures to ensure the correct behaviour. |
|
PSS Measurement: Memory inside container: |
jodh-intel
force-pushed
the
fix-amd64-kata-env
branch
from
b245cbe to
fb5a882
Compare
|
PSS Measurement: Memory inside container: |
jodh-intel
force-pushed
the
fix-amd64-kata-env
branch
from
fb5a882 to
319abd0
Compare
|
Build failed (third-party-check pipeline) integration testing with
|
|
Build failed (third-party-check pipeline) integration testing with
|
|
PSS Measurement: Memory inside container: |
Fix nasty bug which resulted in `kata-env` showing `VMContainerCapable = true` even on amd64 systems without virtualisation support (thankfully `kata-check` still showed the correct results). Added arch-specific tests to avoid any possibility of regression. Fixes kata-containers#660. Signed-off-by: James O. D. Hunt <[email protected]>
jodh-intel
force-pushed
the
fix-amd64-kata-env
branch
from
319abd0 to
35d7672
Compare
|
Build failed (third-party-check pipeline) integration testing with
|
|
ping @egernst, @bergwolf, @devimc, @grahamwhaley. This is a real bug folks - please review :) |
|
I'm not sure I dare re-push as don't want to lose another day waiting for the CI to run... ;( |
|
Sure, np - it was just a note. |
|
PSS Measurement: Memory inside container: |
|
Ping @amshinde. |
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
==========================================
+ Coverage 65.35% 65.35% +<.01%
==========================================
Files 85 85
Lines 9879 9880 +1
==========================================
+ Hits 6456 6457 +1
Misses 2766 2766
Partials 657 657 |
|
CI bliss... |
|
@jodh-intel please backport to stable branches. |
|
Thanks :) |
Fix nasty bug which resulted in
kata-envshowingVMContainerCapable = trueeven on amd64 systems without virtualisation support (thankfullykata-checkstill showed the correct results).Added arch-specific tests to avoid any possibility of regression.
Fixes #660.
Signed-off-by: James O. D. Hunt [email protected]