kata-env: Fix amd64 VM container capable check

[jodh-intel]

Fix nasty bug which resulted in kata-env showing
VMContainerCapable = true even on amd64 systems without virtualisation
support (thankfully kata-check still showed the correct results).

Added arch-specific tests to avoid any possibility of regression.

Fixes #660.

Signed-off-by: James O. D. Hunt [email protected]

[opendev-zuul]

Build failed (third-party-check pipeline) integration testing with
OpenStack. For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

• kata-runsh : RETRY_LIMIT in 7m 50s

[katacontainersbot]

PSS Measurement:
Qemu: 169826 KB
Proxy: 4206 KB
Shim: 8824 KB

Memory inside container:
Total Memory: 2043460 KB
Free Memory: 2003604 KB

[codecov]

Codecov Report

Merging #727 into stable-1.2 will increase coverage by <.01%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##           stable-1.2     #727      +/-   ##
==============================================
+ Coverage       66.89%   66.89%   +<.01%     
==============================================
  Files              85       85              
  Lines            9161     9162       +1     
==============================================
+ Hits             6128     6129       +1     
  Misses           2394     2394              
  Partials          639      639

[grahamwhaley]

Given this is a backport of #661
lgtm

[grahamwhaley]

F27 openshift failure though:

Start Master
In project default on server https://10.0.0.10:8443

You have no services, deployment configs, or build configs.
Run 'oc new-app' to create an application.
Start Node
NAME                 TYPE        CLUSTER-IP   EXTERNAL-IP   PORT(S)                 AGE
service/kubernetes   ClusterIP   172.30.0.1   <none>        443/TCP,53/UDP,53/TCP   0s
Openshift started successfully
1..1
not ok 1 Hello Openshift using Kata Containers
# (in test file hello_world.bats, line 28)
#   `sudo -E oc create -f "${BATS_TEST_DIRNAME}/data/hello-pod-kata.json"' failed
# fedora-27-1033.vexxhost.net   Ready     <none>    6s        v1.10.0+b81c8f8
# W0913 12:27:40.582556   13107 util_unix.go:75] Using "/var/run/crio/crio.sock" as endpoint is deprecated, please consider using full url format "unix:///var/run/crio/crio.sock".
# Image is update to date for docker.io/openshift/hello-openshift@sha256:aaea76ff622d2f8bcb32e538e7b3cd0ef6d291953f3e7c9f556c1ba5baf47e2e
# Error from server (Forbidden): error when creating "/tmp/jenkins/workspace/kata-containers-runtime-fedora-27-PR/go/src/github.com/kata-containers/tests/integration/openshift/data/hello-pod-kata.json": pods "hello-openshift" is forbidden: error looking up service account default/default: serviceaccount "default" not found
# Error from server (NotFound): pods "hello-openshift" not found
# rm: cannot remove '': No such file or directory
# Error from server (NotFound): pods "hello-openshift" not found
# No resources found.